Feat/sloc initial sweep - #28
Conversation
|
Thanks for this @cryptanu! We actually have a very similar one internally :>. I will look into whether we want to open source it. |
It was a great first issue to get the hang of using these skills for me. Would like to have a look at what other primitives your internal tooling may cover that's not present here as well. Ty! |
|
@cryptanu FYI I will look at this skill vs our internal one this week and consider what to do with it. Btw, the CLA lets us potentially include your contribution in our commercial tooling, which helps fund continued maintenance of our open source work. Please accept it and we'll keep working on these skills for everyone's benefit :). |
|
Sure. I'm curious, do the other skills maintain context by internally flattening with Slither on every run. I have an idea to run a "flatten" skill and cache this for future runs. Do lmk if this could improve performance and lower token cost per run. |
Fix ruff lint issues
|
@cryptanu — this has been open since January and you've been responsive throughout. The silence since then is on us, not you, and I'm sorry for it. Two separate things are holding it, and I'd rather name both than leave you guessing again. 1. A product decision that is ours to make, not yours. In January we said ToB has a similar internal tool and we'd decide whether to open-source it. That decision still hasn't been made, and it's the actual blocker — it determines whether this plugin is the SLOC story for this repo or duplicates one we're about to publish. I'm surfacing it rather than answering it, because it isn't mine to answer. @dguido, this needs a yes or no; six months of a first-time contributor waiting on it is the worst of both outcomes. 2. Mechanical gaps, if it does go ahead. These are concrete and quick:
What already passes: plugin README, root README row, all three required sections, SKILL.md at 375 lines, no hardcoded paths, Don't spend time on the mechanical list until item 1 is answered — I don't want you doing work that gets closed. |
Summary